Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some RFCs has incorrect has_pdf information in the datatracker #807

Closed
ietf-svn-bot opened this issue Mar 14, 2012 · 6 comments
Closed

Some RFCs has incorrect has_pdf information in the datatracker #807

ietf-svn-bot opened this issue Mar 14, 2012 · 6 comments
Labels
component: doc/ medium

Comments

@ietf-svn-bot
Copy link

owner:olau@iola.dk resolution_fixed type_defect | by marshall.eubanks@gmail.com

On the datatracker page for this RFC

http://datatracker.ietf.org/doc/rfc6349/

if you click on "pdf" you get

http://www.rfc-editor.org/rfc/rfc6349.pdf

which returns

Object not found!

The requested URL was not found on this server. The link on the
referring page seems to be wrong or outdated. Please inform the author
of that page about the error.

If you think this is a server error, please contact the webmaster.

Error 404

www.rfc-editor.org
Tue Mar 13 13:39:25 2012
Apache/2.2.10 (Linux/SUSE) mod_ssl/2.2.10 OpenSSL/0.9.8h PHP/5.2.13
with Suhosin-Patch mod_python/3.3.1 Python/2.6 mod_perl/2.0.4
Perl/v5.10.0

Database transition conversion error or error in rfc mirror script?

Issue migrated from trac:807 at 2022-03-04 02:29:58 +0000
@ietf-svn-bot
Copy link
Author

@olau@iola.dk commented

Well, in some sense it's neither. :) With the new schema, we don't store the file types in the database. Instead we check the file system and just report back what extensions we've found there. For the RFCs, as far as I can tell, the code is checking the directory /a/www/ietf-ftp/rfc/. So if it finds an rfc6349.pdf in there, it will generate a link.

Now, obviously this is not working as intended. I think the first attempt would be to either make sure this directory is mapping what's in rfc-editor.org/rfc/, or alternatively generate links directly to this directory instead of to the RFC Editor. I'm not familiar enough with the live setup to determine what we should do here, I guess we need some help from Henrik.

@ietf-svn-bot
Copy link
Author

@henrik@levkowetz.com commented

I checked the RFC directory on the datatracker server. There is a pdf file there, with the
name 'rfc6349.txt.pdf', which has been generated from the text file. PDFs which come directly
from the rfc-editor are named rfcNNNN.pdf (without the '.txt' part). We probably should
ignore the 'rfcNNNN.txt.pdf' files for the purpose of putting up the link to the rfc-editor's
pdf file.

@ietf-svn-bot
Copy link
Author

@olau@iola.dk changed status from new to closed

@ietf-svn-bot
Copy link
Author

@olau@iola.dk changed resolution from `` to fixed

@ietf-svn-bot
Copy link
Author

@olau@iola.dk commented

Fixed in 3731f7c:

Split extension at first . when looking for an extension,
prevents us from considering .txt.pdf a PDF for the purpose of RFCs.
Fixes #807.

@ietf-svn-bot
Copy link
Author

@henrik@levkowetz.com changed status from closed to deployed

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: doc/ medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rjsparks @ietf-svn-bot